On Mon, Jun 8, 2009 at 10:29 PM, Ben Goodrich<goodrich....@gmail.com> wrote: > > On Jun 8, 8:08 pm, Ben Goodrich <goodrich....@gmail.com> wrote: >> Thank you. I will do that. -- Ben > > This is now issue 1465 at > > http://code.google.com/p/sympy/issues/detail?id=1465 > > which has my patch. In my opinion, the previous behavior is > inconsistent with the definition of a Jacobian, so I hope the patch > can be committed soon.
Great job! Many thanks. > > The patch also slightly changes the example embedded within the code > to the 3x2 situation I mentioned in the first post on this thread, > which I hope is sufficient for testing the new functionality. I did > not touch sympy/matrices/tests/test_matrices.py but there are already > a few tests there that call the jacobian function that are still > working correctly, so the square Jacobian case seems to not be broken > by the patch. I have added the old doctests into it too + wrote at least one regular test, see the issue. Please review, then I'll push both things in. All such new code has to be tested, otherwise it will break soon again. Ondrej --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to sympy@googlegroups.com To unsubscribe from this group, send email to sympy+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sympy?hl=en -~----------~----~----~----~------~----~------~--~---
