Ok, I see that the Basic/Expr split has been merged, so I will work on this stuff next week.
Cheers, Brian On Tue, Apr 6, 2010 at 5:00 PM, Ondrej Certik <ond...@certik.cz> wrote: > On Wed, Apr 7, 2010 at 12:54 AM, Ondrej Certik <ond...@certik.cz> wrote: >> On Tue, Mar 30, 2010 at 7:32 PM, Ondrej Certik <ond...@certik.cz> wrote: >>> On Tue, Mar 30, 2010 at 11:26 AM, Brian Granger <ellisonbg....@gmail.com> >>> wrote: >>>> Ronan, >>>> >>>> Yes, for my students it doesn't matter, but for us devs it does. I >>>> just left a comment on your branch. I do agree that your branch >>>> should go in before adding any new methods to Basic. >>> >>> For the record, it's this issue: >>> >>> http://code.google.com/p/sympy/issues/detail?id=1798 >>> >>> and this branch: >>> >>> http://github.com/rlamy/sympy/tree/split_Basic >>> >>> I apologize for not looking at this in details so far. I also didn't >>> like the idea initially, but it seems it's a good idea and if >>> everybody agrees to have this in, let's do that. I am busy today, but >>> will have some time in the evening to review it properly. If it >>> simplifies the core, then let's do that. >> >> I have played with this split_Basic branch and all tests pass. It will >> have to be rebased on top of our latest master, but that shouldn't be >> a big problem. >> >> Ronan --- I saw that your split_Basic_pc2 branch seems a bit more >> polished, so I also tested that, all tests pass. Which one should we >> use? >> >> So in general I am ok with this. But I still don't understand exactly >> what should be in Expr and what in Basic. >> >> I see that all arithmetic methods are in Expr, as well as series() and >> related methods. subs(), match() are still in Basic. This should be >> explained in the docstring of Expr, how to decide what should go into >> Expr and what into Basic. >> >> After this is clarified, let's get it in, I can help with that. Brian >> can then implement the rest of the methods in Expr. > > Ah, got it, the branch is actually Basic-split-rebased-2 and it is +1 > from me, as well as Vinzent, so I have pushed this in. > > Nevertheless, a way better docstring for the Expr class, together with > motivation is still missing, can you please fix that? > > Ondrej > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To post to this group, send email to sy...@googlegroups.com. > To unsubscribe from this group, send email to > sympy+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. > > -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to sy...@googlegroups.com. To unsubscribe from this group, send email to sympy+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
