You should submit a pull request only if you feel that your code is ready to be merged in. So 2.
If you just want feedback, you can write to the list with a link to your branch on GitHub. It's even possible for people to leave comments on lines of code without you creating a pull request. You can also create an issue in the issue tracker and put a link to your branch there. Aaron Meurer On Jun 3, 2011, at 1:50 PM, Matthew Rocklin wrote: > Hi Folks, > > Regarding pull requests there are (for me) two competing interests: > > 1) I want feedback on my unfinished code > 2) I want to present a polished product to the SymPy community > > At what stage in my code's development is it proper to submit a pull request? > > -Matt > -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to sympy@googlegroups.com. To unsubscribe from this group, send email to sympy+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
