Related topic. Why does Basic have attributes like is_Rational? Shouldn't that be under Expr?
There has also been talk of not using these in favor of isinstance(obj, obj.func) On Fri, Jun 21, 2013 at 12:24 AM, Chris Smith <smi...@gmail.com> wrote: > > One of the solutions which Christopher Smith suggested was to define a >> BasicBase class in basic.py and migrate these attributes to that class. >> > > My thinking here is to allow non-Basic entities (like Matrix) that may be > encountered (e.g. in solve) to at least have the is_Foo attributes at least > defined. > > > >> All other classes will be derived from this BasicBase class. >> > > Not exactly -- Basic would derive from BasicBase and would thus inherit > the attributes as would all other objects that derive from Basic so very > little would have to be done sympy-wide other than decide of objects that > now derive from object might be better to derive from BasicBase. > > >> I have implemented BasicBase class and made MatrixBase class to derive >> the same. It worked well! >> Due to this change we may need to derive all other classes form this >> BasicBase class. We may also need to write a corresponding tests for the >> same for *everything* in SymPy all together may be a huge task. >> > > I don't think everything has to derive from BasicBase -- only things that > might appear in expressions. > > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sympy+unsubscr...@googlegroups.com. > To post to this group, send email to sympy@googlegroups.com. > Visit this group at http://groups.google.com/group/sympy. > For more options, visit https://groups.google.com/groups/opt_out. > > > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sympy+unsubscr...@googlegroups.com. To post to this group, send email to sympy@googlegroups.com. Visit this group at http://groups.google.com/group/sympy. For more options, visit https://groups.google.com/groups/opt_out.
