Hi Øyvind, Thank you for taking your time looking at the PR's.
Øyvind raised an important concern regarding ordering of terms and arguments in my test strings: https://github.com/sympy/sympy/pull/7355 Are these platform dependent (still)? If so: I might need to make those tests more robust not to unsettle users of other platforms who might get test failures (even though those test failures would be benign since actual code generated would still work as expected)? Unfortunately I do not have access to Mac / Windows atm. On Friday, 4 April 2014 07:46:21 UTC+2, Øyvind Jensen wrote: > > Hi Björn, > It is really cool that you are working on this, thanks for the PRs! I am > not uptodate on the inner workings of SymPy any longer, but I will take a > look at the patches and see if there is anything I can add. > > Øyvind > > > On Wednesday, April 2, 2014 1:13:52 PM UTC+2, Björn Dahlgren wrote: >> >> Hi! >> >> Since I haven't opened any particular issues but only PR's I thought >> maybe I should announce them here so they won't go unnoticed. >> >> https://github.com/sympy/sympy/pulls/bjodah >> >> They are: >> >> - Avoid superfluous CSEs from Idx and IndexedBase >> instances<https://github.com/sympy/sympy/pull/7347> >> - Makes IndexedBase consistent with Symbol wrt to latex >> printing<https://github.com/sympy/sympy/pull/7354> >> - Fix coeff for indexed <https://github.com/sympy/sympy/pull/7355> >> >> I made all three PRs from modifications I needed to do in order for me to >> productively use SymPy for code generation of finite difference >> formulae in a larger C++ code base. Hence they are in the spirit of using >> tensor.Indexed, tensor.Idx and tensor.IndexedBase in a more general >> setting than just tensors. (I could picture them being moved to core at >> some point even). >> >> I have some more modifications in the pipline but I already forsee merge >> issues wrt to changing argument orders in docstrings and tests, >> so before I submit any more PRs I think it would be good to have these >> reviewed and merged (or rejected if you disagree with me). >> >> Looking forward to your feeback (those of you interested)! >> >> Regards >> /Björn >> > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/a0470860-bce5-4f22-9b6a-3131f629e585%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
