As Matthew noted, please appeal to me if you can't reach a consensus. The point of the BDFL model is to have someone come in and make a final decision, before the community tears itself apart.
I admit that I don't have time to read every pull request any more, and as Joachim noted, I also try to avoid bikesheds. So if you think such a situation is necessary, please ping me either via private email or Google Hangouts, in case I don't see your ping on GitHub. The point is to avoid people hating each other over petty things, so it's better to not wait forever (but also I don't want people to hate me, so I'll only do it when absolutely necessary). Regarding locking issues on pull requests, the feature was added by GitHub to protect against a very rare situation where an issue goes viral (usually on Hacker News) and dozens of people who have never participated in the community before come in to offer their opinions. It's a situation that, as far as I know, SymPy hasn't had, and we should hope we never do. It mostly affects very large projects (like jquery) or controversial projects (like that tip4commit issue I referenced in another thread). I think personally GitHub should have made this feature much less hidden, but there you go. For members of the community, even people who participate less and don't have push access like Jachim, we should not block them. Aaron Meurer On Fri, Jan 2, 2015 at 3:54 PM, Ondřej Čertík <ondrej.cer...@gmail.com> wrote: > On Fri, Jan 2, 2015 at 11:30 PM, Sergey B Kirpichev > <skirpic...@gmail.com> wrote: > > On Fri, Jan 02, 2015 at 10:19:48PM +0100, Ondřej Čertík wrote: > >> I have unlocked the PR (https://github.com/sympy/sympy/pull/8538). > >> > >> Sergey, if there is ever need for such a thing (I actually didn't even > >> know you can lock a PR), please discuss this with me first. > > > > Ok, I consider two possibilities. Either lock PR, or > > close it. I don't think, that other reviewers should go through > > unproductive discussion thread. > > > > Review should be helpful. For example, I suppose, that people > > read code (and run, if that's appropriate) before commenting on it. > > It seems for me, this is not the case... > > Yes. And Joachim admitted that he might have discussed unproductively > (in another thread few minutes ago), so I think next time just ask to > finish the discussion, since it seems unproductive, and/or bring it to > Aaron's attention, as he is ultimately responsible for any code > decisions. As Matthew suggested above. > > > > >> not as some kind of community moderators > > > > Please take into account, that this is my PR. > > Exactly, *especially* if it is your PR, you need to distinguish > between the two hats that you have: > > 1) the author of a PR > 2) having push access > > and you should not use the power of 2) for 1), i.e. for your own PRs, > the best is to behave like if you didn't even have a push access. > > Ondrej > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sympy+unsubscr...@googlegroups.com. > To post to this group, send email to sympy@googlegroups.com. > Visit this group at http://groups.google.com/group/sympy. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/CADDwiVDEmi60KfXiS%3DavODc%2B2NGQwa8wC0o_FUA8Tb1N2xuvPg%40mail.gmail.com > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sympy+unsubscr...@googlegroups.com. To post to this group, send email to sympy@googlegroups.com. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAKgW%3D6K88wdeQECu4fPT4H0daRkdX8auQ-E9dB2KyrPuF28AKg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
