The test check failures you see are from something else, not your README changes. We don't check anything about the readme other than it being present.
Jason moorepants.info +01 530-601-9791 On Sun, Mar 3, 2024 at 12:09 PM Spiros Ts <tsiouprosspi...@gmail.com> wrote: > Author: Spiros Tsioupros > Github: https://github.com/Spiros7bit > email: tsiouprosspi...@gmail.com > > Hello community, I made a pull request to add some links to README.md. > While 63/68 checks are passed, 5 errors about test and > test_optional_dependencies are thrown. I had read in the Development > Workflow Process > <https://docs.sympy.org/dev/contributing/new-contributors-guide/workflow-process.html> > that we should write tests when making pull requests for code changes. > > My question is: Do we have to write a test when we make changes to > README.md or is the problem elsewhere? > > pull request link <https://github.com/sympy/sympy/pull/26294> is here. > > Yours sincerely. > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sympy+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/0d348c35-8350-4f7c-a787-89d7ac7ea89fn%40googlegroups.com > <https://groups.google.com/d/msgid/sympy/0d348c35-8350-4f7c-a787-89d7ac7ea89fn%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sympy+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAP7f1AiR-vgX3Zu6tiA8%2BFBWsVQEX6jttoTApJBaousZdW2_GA%40mail.gmail.com.
