Author: ruwan
Date: Tue Oct 16 19:57:02 2007
New Revision: 585335
URL: http://svn.apache.org/viewvc?rev=585335&view=rev
Log:
Fixing the logs for task with a little re-factoring
Removed:
webservices/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/config/xml/StartupWrapperFactory.java
Modified:
webservices/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/config/xml/StartupFinder.java
webservices/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/startup/quartz/SimpleQuartzFactory.java
Modified:
webservices/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/config/xml/StartupFinder.java
URL:
http://svn.apache.org/viewvc/webservices/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/config/xml/StartupFinder.java?rev=585335&r1=585334&r2=585335&view=diff
==============================================================================
---
webservices/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/config/xml/StartupFinder.java
(original)
+++
webservices/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/config/xml/StartupFinder.java
Tue Oct 16 19:57:02 2007
@@ -124,33 +124,21 @@
*/
public Startup getStartup(OMElement element) {
- String name = element.getAttributeValue(new
QName(XMLConfigConstants.NULL_NAMESPACE, "name"));
- if (name == null) {
- String msg = "Name for an startup is required, missing name in the
startup";
- if (log.isDebugEnabled()) {
- log.debug(msg);
- }
- throw new SynapseException(msg);
- }
-
QName qName = element.getQName();
if (log.isDebugEnabled()) {
- log.debug("getStartup(" + qName + ")");
+ log.debug("Creating the Startup for : " + qName);
}
Class cls = (Class) factoryMap.get(qName);
if (cls == null) {
- String msg = "Unknown Startup type referenced by startup element :
"
- + qName;
+ String msg = "Unknown Startup type referenced by startup element :
" + qName;
log.error(msg);
throw new SynapseException(msg);
}
try {
StartupFactory sf = (StartupFactory) cls.newInstance();
- Startup startup = sf.createStartup(element);
- startup.setName(name);
- return startup;
+ return sf.createStartup(element);
} catch (InstantiationException e) {
String msg = "Error initializing configuration factory : " + cls;
Modified:
webservices/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/startup/quartz/SimpleQuartzFactory.java
URL:
http://svn.apache.org/viewvc/webservices/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/startup/quartz/SimpleQuartzFactory.java?rev=585335&r1=585334&r2=585335&view=diff
==============================================================================
---
webservices/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/startup/quartz/SimpleQuartzFactory.java
(original)
+++
webservices/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/startup/quartz/SimpleQuartzFactory.java
Tue Oct 16 19:57:02 2007
@@ -58,12 +58,20 @@
public Startup createStartup(OMElement el) {
if (log.isDebugEnabled()) {
- log.debug("Creating SimpleQuartz startup");
+ log.debug("Creating SimpleQuartz Task");
}
if (el.getQName().equals(TASK)) {
SimpleQuartz q = new SimpleQuartz();
+
+ String name = el.getAttributeValue(
+ new QName(XMLConfigConstants.NULL_NAMESPACE, "name"));
+ if (name != null) {
+ q.setName(name);
+ } else {
+ handleException("Name for a task is required, missing name in
the task");
+ }
// set the task class
OMAttribute classAttr = el.getAttribute(new QName("class"));
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
