On Jan 15, 2014, at 2:55 PM, Mark Hammond <[email protected]> wrote:
> On 15/01/2014 11:46 PM, Chris Karlof wrote: >> markh <member:markh>:that about:accounts doesn't give me the option to >> sign out like it did a few days ago >> [2:40pm]ckarlof <member:ckarlof>:gotcha >> [2:41pm]ckarlof <member:ckarlof>:I was speaking with ryan and john today >> [2:41pm]ckarlof <member:ckarlof>:the thinking is that the sync prefs >> menu would offer an "Unlink" option >> [2:41pm]ckarlof <member:ckarlof>:like it does now >> [2:41pm]ckarlof <member:ckarlof>:and that would log you out >> [2:41pm]ckarlof <member:ckarlof>:about:accounts is a bit of a lame duck >> after you're logged in >> [2:42pm]ckarlof <member:ckarlof>:and certainly shouldn't load remote >> code after you're logged in >> >> So wire up "unlink" to the warning message and then call >> FxAccounts.signout >> (http://mxr.mozilla.org/mozilla-central/source/services/fxaccounts/FxAccounts.jsm#110) >> > > I might be a but confused (or cookies etc are screwing me?), but > about:accounts seems to think I'm logged in even after I restart after > deleting signedInUser.json - so it seems the client can't do this by itself. > I can't reproduce this on current nightly using our latest server deployment. John and Ryan are proposing that you "logout" via the "Unlink" link in Sync preferences menu, not about:accounts. There should be no UI flow that gets you to about:accounts after you are logged in. If the user types in about:accounts manually after signing in, it should show them something, but it shouldn't load the remotely hosted code - there's no need to, the user is already logged in. Maybe it shows a "unlink" button as well, but that would be non-hosted UI. -chris >> There may be some sync cleanup to do, too. Maybe Sync can handle this in >> its onlogout observer. > > Yeah, that's what I was assuming - about:accounts does the logout and the > client handles it via the observer. > > I've no idea why IRC is failing even though mail and the web seems to work. > There must be a conspiracy :) > >> >> -chris >> > _______________________________________________ Sync-dev mailing list [email protected] https://mail.mozilla.org/listinfo/sync-dev
