On 2014-11-06, 3:59 PM, Richard Newman wrote:
Isn't search history a subset of form history?
(Bug 461820 prevented it from being saved/retrieved for web forms, but
as far as I know the storage is still shared.)
You’re right, and it syncs (between desktops). Neat! Thanks for pointing that
out!
The downsides for this that I can see:
* We don’t sync form history on any other platforms right now. Is it overkill
to implement form history syncing (whole or partial) in order to get search
terms? (A partial implementation is somewhat incompatible with Sync’s
expectation that clients can reupload all the data when necessary, but we can
gloss over that).
We do sync form history on Android -- it was one of the first things I
ever wrote as a MoCo employee. Collection "forms", only columns are
"key" and "value" IIRC.
* My Sync account has over 700 form records. Locally I have about 10k (there’s
a 60-day TTL). 4k of those local records are searches. For a new pairing of two
devices, we’re asking them to throw away more than half the data they
downloaded in order to get to the searches. Perhaps that’s not a big deal.
* We lose the ability to record data that aren’t tracked in the Sync form
history record format (e.g., counts and times).
So perhaps this proposal becomes: expand the form history record format (which
we already want to do, because it’s incredibly limited), document that
name=“search-history” is special, and implement a partial form history sync on
other platforms.
Does anyone see problems with doing so, other than the issues outlined for
similar extensions in Bug 720592 and Bug 555755?
Is there any plan to change how this is done on desktop?
I don't understand how "the name search-history" makes sense. This
could identify a single record by guid, but the forms record format only
stores one key=value pair.
I think separating search history from forms in general is an excellent
idea. Off the top, geotagging search history might be useful; it's
probably not useful for forms.
Nick
_______________________________________________
Sync-dev mailing list
[email protected]
https://mail.mozilla.org/listinfo/sync-dev
