Patches item #2100533, was opened at 2008-09-09 00:13 Message generated for change (Comment added) made by pabs3 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=757418&aid=2100533&group_id=144022
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Genete (genete) Assigned to: Genete (genete) Summary: Custom document filename prefix added to settings dialog Initial Comment: This patch is a continuation of the previous one [2087747]. I've added the filename prefix for new documents to the Settings dialog. It allows to remember it between sessions and immediately if it is applied by the settings dialog. Also to make it more consistent and readable I've created a new tab for the document custom settings. It has been called "Document". The new tab holds now the "Preferred filename prefix" (a text entry) the "Preferred Document X size" and "Preferred Document Y size" (both spin buttons). They also have tool tips added. I would like to highlight that there were two code lines that did a check to know if the current default filename exists without the added incremental index. They are: - if (as.find(DEFAULT_FILENAME_PREFIX) != 0) + if (as.find(custom_filename_prefix.c_str()) != 0) in app.cpp and - return get_file_name().find(DEFAULT_FILENAME_PREFIX) != 0; + return get_file_name().find(App::custom_filename_prefix.c_str()) != 0; in instance.cpp I wonder if use the custom filename prefix would broke something. I've opted to use it and don't let the old DEFAULT_FILENAME_PREFIX because I think it would not work in that case. Please let me know your opinion. I'll continue working on it. Cheers Genete ---------------------------------------------------------------------- >Comment By: Paul Wise (pabs3) Date: 2008-09-09 10:55 Message: You could check for the new functions in configure.ac and use them when available and use the old ones when not. I believe I did something similar for the about dialog, check the code for that and the configure.ac. ---------------------------------------------------------------------- Comment By: Genete (genete) Date: 2008-09-09 05:06 Message: Zelgadis has applied the patch and confirmed that it doesn't compile for older GTK versions than 2.12 (2.10 in his case). So I've modified the conflictive code and used a deprecated version of tool tips addition. In my opinion it should be some day updated to the latest version, but I think it would be fine by now. Attached is the patch file modified with the commented things. File Added: document_prefix_patch2.txt ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=757418&aid=2100533&group_id=144022 ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Synfig-devl mailing list Synfig-devl@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/synfig-devl
