> On 2008-09-27 05:07:07.304369, Gerco Ballintijn wrote: > > synfig-core/trunk/configure.ac, line 354 > > <http://patches.synfig.org/r/5/diff/1/?file=18#file18line354> > > > > Why place this code here (separated from the rest) and not with the > > rest of the libjpeg configure code further down below? Wouldn't combining > > these two pieces into one make the libjpeg part more comprehensible? > > wrote: > The configure.ac is meant to be separated into several sections. This bit > is in the arguments section, which is the right place to put it.
I mentioned this because other configure code, such as for libavcodec and friends, is not split up like that. Would you suggest changing those as well? - Gerco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/5/#review17 ----------------------------------------------------------- On None, rubikcube wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://patches.synfig.org/r/5/ > ----------------------------------------------------------- > > Review request for Synfig. > > > Summary > ------- > > Added a configure flag to switch on/off jpeg support. This enables turning > off jpeg output, even if libjpeg is available on the system. The same might > be useful for tiff and mng. > > This is my very first dealing with autoconf, so please criticize if there's > anything strange about the patch. I'm sure the patch is still rather ugly > still. > > > Diffs > ----- > > > Diff: http://patches.synfig.org/r/5/diff > > > Testing > ------- > > Tested on gentoo linux and amd64, synfig from svn HEAD. Tried configure > --with[out]-jpeg, synfigstudio then did not show/showed jpeg as an option in > the render menu. > > > Thanks, > > rubikcube > > ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Synfig-devl mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/synfig-devl
