----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/17/ -----------------------------------------------------------
(Updated 2009-04-12 00:06:02.782806) Review request for Synfig. Changes ------- The patch situation is rather nasty. However, I'm confident it isn't my code that is causing the problem. As a hack-ish solution, I ran "diff" on the rejected file (as opposed to "svn diff"), and pasted the output into my patchfile. The output formatting is different for that one file, so it fails the Review Board view system. However, the patch command works fine. I tested the result, and it compiles properly. Summary ------- Suggestion 3 from the forum poll: Outline/Fill color system * All new layers are shaded with the fill color (except Outlines, which are shaded with the outline color) * When an outline and region are created together, this behavior does not change * Gradients are in the direction fill->outline * Counterclockwise curve gradients have the same behavior as regions Diffs (updated) ----- /synfig-studio/trunk/src/gtkmm/dialog_color.h 2355 /synfig-studio/trunk/src/gtkmm/dialog_color.cpp 2355 /synfig-studio/trunk/src/gtkmm/mod_palette/dock_paledit.cpp 2355 /synfig-studio/trunk/src/gtkmm/state_bline.cpp 2355 /synfig-studio/trunk/src/gtkmm/state_circle.cpp 2355 /synfig-studio/trunk/src/gtkmm/state_draw.cpp 2355 /synfig-studio/trunk/src/gtkmm/state_eyedrop.cpp 2355 /synfig-studio/trunk/src/gtkmm/state_fill.cpp 2355 /synfig-studio/trunk/src/gtkmm/state_polygon.cpp 2355 /synfig-studio/trunk/src/gtkmm/state_rectangle.cpp 2355 /synfig-studio/trunk/src/gtkmm/state_sketch.cpp 2355 /synfig-studio/trunk/src/gtkmm/state_star.cpp 2355 /synfig-studio/trunk/src/gtkmm/state_stroke.cpp 2355 /synfig-studio/trunk/src/gtkmm/widget_defaults.h 2355 /synfig-studio/trunk/src/gtkmm/widget_defaults.cpp 2355 /synfig-studio/trunk/src/synfigapp/action.cpp 2355 /synfig-studio/trunk/src/synfigapp/actions/colorset.h 2355 /synfig-studio/trunk/src/synfigapp/actions/colorset.cpp 2355 /synfig-studio/trunk/src/synfigapp/canvasinterface.cpp 2355 /synfig-studio/trunk/src/synfigapp/inputdevice.h 2355 /synfig-studio/trunk/src/synfigapp/inputdevice.cpp 2355 /synfig-studio/trunk/src/synfigapp/main.h 2355 /synfig-studio/trunk/src/synfigapp/main.cpp 2355 Diff: http://patches.synfig.org/r/17/diff Testing ------- Compiles & runs. Everything seems to function properly. Thanks, nikitakit ------------------------------------------------------------------------------ This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com _______________________________________________ Synfig-devl mailing list Synfig-devl@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/synfig-devl
