----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/26/#review70 -----------------------------------------------------------
Ship it! Looks good to me, except for the minor issue below. Ship it! synfig-studio/trunk/src/gtkmm/zoomdial.h <http://patches.synfig.org/r/26/#comment120> Gratuitous whitespace change. - Paul On 2009-05-09 02:21:55.427285, Gerco Ballintijn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://patches.synfig.org/r/26/ > ----------------------------------------------------------- > > (Updated 2009-05-09 02:21:55.427285) > > > Review request for Synfig. > > > Summary > ------- > > This patch provides a refactoring of the canvas zoom button minibar. It was > inspired by pabs comments on the WIP patch for frame navigation buttons. > > The refactoring consists of: > * Removing the use of a CPP macro to reuse C++ code (use a method call > instead). > * Making fields private that can be private (fields should be private by > default). > * Moving the constructor code to zoomdial.cpp (normal code should in general > not be in header files). > * Some minor layout changes. > > > Diffs > ----- > > synfig-studio/trunk/src/gtkmm/zoomdial.h 2375 > synfig-studio/trunk/src/gtkmm/zoomdial.cpp 2375 > > Diff: http://patches.synfig.org/r/26/diff > > > Testing > ------- > > Compiles, runs, and looks the same. > > > Thanks, > > Gerco > > ------------------------------------------------------------------------------ The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your production scanning environment may not be a perfect world - but thanks to Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700 Series Scanner you'll get full speed at 300 dpi even with all image processing features enabled. http://p.sf.net/sfu/kodak-com _______________________________________________ Synfig-devl mailing list Synfig-devl@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/synfig-devl
