> On 2009-05-17 04:38:14.529435, Paul Wise wrote:
> > What about using Gtk::MessageDialog to save some code?
> 
> Gerco Ballintijn wrote:
>     Yep, that seems a good idea. I'll try that later.

I looked at the Gtk::MessageDialog but it appears that, unlike the patch, it 
doesn't allow us to set the labels of the buttons. So, it's not an option to 
use that, and we have to consider the patch as is.


- Gerco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://patches.synfig.org/r/27/#review73
-----------------------------------------------------------


On 2009-05-17 04:06:32.805717, Gerco Ballintijn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://patches.synfig.org/r/27/
> -----------------------------------------------------------
> 
> (Updated 2009-05-17 04:06:32.805717)
> 
> 
> Review request for Synfig.
> 
> 
> Summary
> -------
> 
> This patch is an extended version of the patch that Bombe added added to 
> SourceForge.net on 2009-02-15 (#2602803: "Patch: Improve UI on crash recovery 
> dialog."). I cleaned up the code a bit by making it more consistent with 
> surrounding code. Otherwise, it still more or less the same. The attached 
> images show the effect of the patch.
> 
> 
> Diffs
> -----
> 
>   synfig-studio/trunk/src/gtkmm/app.cpp 2376 
>   synfig-studio/trunk/src/gtkmm/canvasview.cpp 2376 
>   synfig-studio/trunk/src/synfigapp/uimanager.h 2376 
>   synfig-studio/trunk/src/synfigapp/uimanager.cpp 2376 
> 
> Diff: http://patches.synfig.org/r/27/diff
> 
> 
> Testing
> -------
> 
> Compiles, runs, and shows the improved dialog.
> 
> 
> Screenshots
> -----------
> 
> Old recovery dialog
>   http://patches.synfig.org/r/27/s/3/
> New recovery dialog
>   http://patches.synfig.org/r/27/s/4/
> 
> 
> Thanks,
> 
> Gerco
> 
>


------------------------------------------------------------------------------
Are you an open source citizen? Join us for the Open Source Bridge conference!
Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250.
Need another reason to go? 24-hour hacker lounge. Register today!
http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org
_______________________________________________
Synfig-devl mailing list
Synfig-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/synfig-devl

Reply via email to