Bugs item #3405023, was opened at 2011-09-06 07:59
Message generated for change (Comment added) made by jcome
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=757416&aid=3405023&group_id=144022
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Usability
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: David Rylander (rylleman)
Assigned to: Nobody/Anonymous (nobody)
Summary: Rename zoom layer to scale
Initial Comment:
I propose to rename the zoom layer to SCALE as this is more accurate to what it
does.
Zoom is more commonly associated with cameras where they zoom in on the whole
image. Zoom layer manipulates a layer by scaling it up or down.
----------------------------------------------------------------------
>Comment By: Yu Chen (jcome)
Date: 2012-03-22 08:10
Message:
When I doing preview window improvement job, I meet the same kind of issue:
There is a "Zoom" label, that means "Quality" from a user's perspective,
but when I look into the code, I find that option meaning is a "Zoom" than
"Quality" from coder's perspective. So I just renamed the String which
exposed on UI and let the others as it is.
For the icon, you can take a look at
synfig-studio/src/gui/iconcontroller.cpp :
// Transform Layers
INIT_STOCK_ICON(layer_transform_rotate,"layer_transform_rotate_icon."IMAGE_EXT,_("Rotate
Layer"));
INIT_STOCK_ICON(layer_transform_translate,"layer_transform_translate_icon."IMAGE_EXT,_("Translate
Layer"));
INIT_STOCK_ICON(layer_transform_zoom,"layer_transform_zoom_icon."IMAGE_EXT,_("Zoom
Layer"));
I don't think other metaphor is better than a magnifier :)
----------------------------------------------------------------------
Comment By: Bertrand Grégoire (berteh)
Date: 2012-03-22 07:20
Message:
hum... cannot attach a file here. would you rather get the patch here or in
the forum?
B.
----------------------------------------------------------------------
Comment By: Bertrand Grégoire (berteh)
Date: 2012-03-22 07:18
Message:
draft patches attached. Requires more work to get the icon updated: studio
does not associate automatically the icon
synfig-studio/images/layer_transform_scale_icon.png (or sif) to this layer
by only changing
SYNFIG_LAYER_SET_NAME(Zoom,"scale"); ... what do I need to do to get the
icon right?
One (more) question for my education:
if, in synfig-core/src/modules/lyr_std/zoom.cpp, if I use the following to
get a shortcut in the Layer menu:
SYNFIG_LAYER_SET_LOCAL_NAME(Zoom,N_("_Scale"));
then this string _Scale shows (with the underscore) as default layer name
in studio. To avoid this I dropped the shortcut. Is there a means to have
the shortcut AND the default name with no underscore?
I'll updated the patch when I figure how to fix the icon issue. don't apply
yet.
Thanks.
----------------------------------------------------------------------
Comment By: Genete (genete)
Date: 2012-03-20 00:43
Message:
@berteh:
Rename the localizable string from "Zoom" to "Scale" is the easiest and
secure way to fix this. Rename the internal label from "zoom" to "scale"
would imply many other places to touch and the benefit for the user is
zero.
There are some other objects that the internal name doesn't fit the user
interface name. It is not a big deal and only affects to the coder.
----------------------------------------------------------------------
Comment By: Bertrand Grégoire (berteh)
Date: 2012-03-19 05:44
Message:
I could have a look at this once it's a confirmed request.
Would you rather see me try to fix it only on the cosmetics (labels and
language files) or the very heart (core classes, methods and more)?
Should the name of the "zoom" attribute of each layer be changed to
"scaling" or "scale" as well? and if yes, should it be "scaling" or
"scale"?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=757416&aid=3405023&group_id=144022
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Synfig-devl mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/synfig-devl
