Yes, you're right. That looks more reasonable.
Regarding to the branch to use, the single_window one looks to have the
other one partially merged into it. In any case I don't think that continue
that branch is a good idea having the option of cherry pick whatever you
want. The number of commits aren't so big to be afraid about use cherry
pick in this case, I think.
Greetings
Carlos
2013/9/27 Konstantin Dmitriev <[email protected]>
>
> 27.09.2013 15:42 пользователь "Carlos López González" <[email protected]>
> написал:
>
> >
> > Hi djay,
> > the strategy of merge jcome/single_window into your branch or ask jcome
> to rebase his branch onto master is not the right way, I think.
> >
> > The right way would be to redo jcome/single_window branch onto master by
> doing cherry picks of it. You can do that without need to ask to jcome.
> Meanwhile if there is any conflict, fix it ammending the commit or adding
> extra commits to your branch.
> >
> > Once you have jcome's branch up to date to master on your repo, you can
> unify his strategy with your fixes for menus, so they can join.
> >
> > IIRC, the single_window strategy was this (Yu, please correct me if I'm
> wrong):
> > 1) Turn Toolbox into a panel and make canvas the main window.
> > 2) Make canvas window a tabbed document holder.
> > 2) Dock everything around canvas window (toolbox panel and the other
> panels)
>
> As I have mentioned during our LGM discussion, I`m against of turning
> toolbox to panel.
>
> Also, the steps should be a bit different:
> 1. Turn the hidden canvas menu into normal menu, like every application
> have. This menu should belong to canvas window.
> 2. Make a toolbar at the top of canvas window.
>
> At this point we can merge this feature and release.
>
> 3. Make canvas window a tabbed document holder.
>
> Merge into master again.
>
> 4. Merge toolbox with canvas window and make it primary.
>
> 5. Dock all panels into canvas window.
>
> Also, my question: which branch should we use? The one called
> single_window or other one, mentioned in my letter?
>
> K.
>
> >
> > Cheers!
> >
> >
> > 2013/9/27 d/j/a/y is free <[email protected]>
> >>
> >> Le 27/09/2013 Carlos a écrit :
> >> > merge jcome's....
> >> > https://github.com/jcome/synfig/commits/single_window
> >> >
> >> Humm look like it will not be strait to merge.... (ui infos for example)
> >> I have done a quick look in thge code and detected some outdated duck
> >> strings, and others little 'problem' (strings without localization
> >> _("....") )
> >>
> >> I agree with you carlos and konstantin, it's not a good idea to work on
> >> same feature in two branchs... that's was the sense of my first message
> >> about toolbox conversion. Did i was too quick to implement ? ;-)
> >>
> >> Yu, do you think to follow your work on single_branch ?
> >> Even if not, can you update single_window branch with last master ?
> >>
> >> --
> >> [##___l'urgent est remis a demain, l'impossible est en cours...___##]
> >>
> >>
> >>
> ------------------------------------------------------------------------------
> >> October Webinars: Code for Performance
> >> Free Intel webinars can help you accelerate application performance.
> >> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the
> most from
> >> the latest Intel processors and coprocessors. See abstracts and
> register >
> >>
> http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
> >> _______________________________________________
> >> Synfig-devl mailing list
> >> [email protected]
> >> https://lists.sourceforge.net/lists/listinfo/synfig-devl
> >
> >
> >
> >
> > --
> > Carlos
> > http://synfig.org
> >
> >
> ------------------------------------------------------------------------------
> > October Webinars: Code for Performance
> > Free Intel webinars can help you accelerate application performance.
> > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> > the latest Intel processors and coprocessors. See abstracts and register
> >
> >
> http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
> > _______________________________________________
> > Synfig-devl mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/synfig-devl
> >
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
> _______________________________________________
> Synfig-devl mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/synfig-devl
>
>
--
Carlos
http://synfig.org
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
_______________________________________________
Synfig-devl mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/synfig-devl
