On Mon, Jun 22, Konstantin Dmitriev wrote:

> 2015-06-22 15:32 GMT+06:00 Olaf Hering <o...@aepfle.de>:
> >
> > CFLAGS and CXXFLAGS may contain other valid options than just "-g".
> > Leave anything related to debuginfo as instructed by the user to avoid
> > syntax errors. Prepend the private debug knobs to give the user a
> > chance to pass its own knobs to the compiler.
> >
> > This patch fixes g++ -grecord-gcc-switches and other -g variants.
> >
> > Signed-off-by: Olaf Hering <o...@aepfle.de>
> >
> > ---
> >  m4/subs.m4 |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Index: synfig-1.0/m4/subs.m4
> > ===================================================================
> > --- synfig-1.0.orig/m4/subs.m4
> > +++ synfig-1.0/m4/subs.m4
> > @@ -88,8 +88,8 @@ AC_DEFUN([AC_ARG_DEBUG],
> >         esac
> >
> >
> > -       CXXFLAGS="`echo $CXXFLAGS | sed s:-g::` $debug_flags"
> > -       CFLAGS="`echo $CFLAGS | sed s:-g::` $debug_flags"
> > +       CXXFLAGS="$debug_flags $CXXFLAGS"
> > +       CFLAGS="$debug_flags $CFLAGS"
> >
> >         AC_MSG_RESULT([$debug_flags])
> >  ])
> 
> Hello, Olaf!
> 
> Thank you for the patch, the issue is already fixed in the master
> branch - 
> https://github.com/synfig/synfig/commit/cb8a2fff9ea5d11f7819cbc7a7c3c177098d2a63

In what way is that a fix? The arguments for the compiler come from
CFLAGS. They are not supposed to be modified by configure, but perhaps
configure can prepend stuff.

Also it does not seem to work, maybe I misunderstand the patch?
CFLAGS="-gwww a" ; CFLAGS="`echo $CFLAGS | sed 's:-g\s::' | sed 's:-g$::'` 
$debug_flags" ; echo "$CFLAGS"
-gwww a

Olaf

------------------------------------------------------------------------------
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors 
network devices and physical & virtual servers, alerts via email & sms 
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
_______________________________________________
Synfig-devl mailing list
Synfig-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/synfig-devl

Reply via email to