Branch: refs/heads/master
Home: https://github.com/synfig/synfig
Commit: 4b6602f4f7d86f3460f131f01b7d02a12b1af098
https://github.com/synfig/synfig/commit/4b6602f4f7d86f3460f131f01b7d02a12b1af098
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2021-07-05 (Mon, 05 Jul 2021)
Changed paths:
M synfig-studio/src/synfigapp/value_desc.h
Log Message:
-----------
synfigapp: prefer nullptr rather 0 or NULL
Commit: f27da8975d7eec3e1bc9d1b88f2ae9b7e7d82859
https://github.com/synfig/synfig/commit/f27da8975d7eec3e1bc9d1b88f2ae9b7e7d82859
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2021-07-05 (Mon, 05 Jul 2021)
Changed paths:
M synfig-studio/src/synfigapp/value_desc.h
Log Message:
-----------
synfigapp: ValueDesc: don't make me try to remember magic numbers
Commit: 7055eb5cc5868b9707fcf027acc5521e65cdac4f
https://github.com/synfig/synfig/commit/7055eb5cc5868b9707fcf027acc5521e65cdac4f
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2021-07-05 (Mon, 05 Jul 2021)
Changed paths:
M synfig-studio/src/synfigapp/value_desc.h
Log Message:
-----------
synfigapp: ValueDesc: don't cast when it isn't necessary
Commit: 5032236311e340a09755e3b1677809743b4fee06
https://github.com/synfig/synfig/commit/5032236311e340a09755e3b1677809743b4fee06
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2021-07-05 (Mon, 05 Jul 2021)
Changed paths:
M synfig-studio/src/synfigapp/value_desc.h
Log Message:
-----------
synfigapp: ValueDesc: remove unused constructors
one is commented-out since 2005
Commit: 1f083b22717caf671803db99fc41758173ef06e4
https://github.com/synfig/synfig/commit/1f083b22717caf671803db99fc41758173ef06e4
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2021-07-05 (Mon, 05 Jul 2021)
Changed paths:
M synfig-studio/src/synfigapp/value_desc.h
Log Message:
-----------
synfigapp: ValueDesc: remove scalar: it's always 1.0
It's only valid for ValueDesc for LinkableValueNode, and it
is never set besides in constructor, where its values is set to 1.0
Commit: 9568797e50499bc7b541df6d1210075d70f7cd17
https://github.com/synfig/synfig/commit/9568797e50499bc7b541df6d1210075d70f7cd17
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2021-07-05 (Mon, 05 Jul 2021)
Changed paths:
M synfig-studio/src/synfigapp/actions/valuedesclink.cpp
Log Message:
-----------
ValueDescLink: link_scalar is always 1.0
Set link_scalar value:
- if ValueDesc is Linkable valuenode, ValueDesc::get_scalar returns 1.0
- otherwise, 1.0
Commit: 0edff44caab07d0681174b5ab949e030ff13d9e7
https://github.com/synfig/synfig/commit/0edff44caab07d0681174b5ab949e030ff13d9e7
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2021-07-05 (Mon, 05 Jul 2021)
Changed paths:
M synfig-studio/src/synfigapp/actions/valuedesclink.cpp
M synfig-studio/src/synfigapp/actions/valuedesclink.h
M synfig-studio/src/synfigapp/value_desc.h
Log Message:
-----------
ValueDescLink: if link_scalar is 0.0 or 1.0, this comparison is always false
ValueDesc::get_scalar() returns 1.0
ValueDesc::get_scalar() * 0.0 or 1.0 is always >= 0
So, the comparison is useless, also link_scalar
Commit: 4a78b7335c02c54bb597dd6cec88c7a24beff8e4
https://github.com/synfig/synfig/commit/4a78b7335c02c54bb597dd6cec88c7a24beff8e4
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2021-07-05 (Mon, 05 Jul 2021)
Changed paths:
M synfig-studio/src/synfigapp/actions/valuedesclink.cpp
M synfig-studio/src/synfigapp/value_desc.h
Log Message:
-----------
ValueDescLink: remove useless code
if(iter_scalar*current_scalar < 0) is always false because
get_scalar() used to be 0,0 or 1.0 only
So, the comparison is useless and so this whole section as
it would only change the found_inverse to true - but it would
never actually do it.
As this was the last code that would use ValueDesc::get_scalar(),
this method can be safely removed.
Commit: a65fcc53f0e05410abc1989ba7102cb492fc71e5
https://github.com/synfig/synfig/commit/a65fcc53f0e05410abc1989ba7102cb492fc71e5
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2021-07-05 (Mon, 05 Jul 2021)
Changed paths:
M synfig-studio/src/synfigapp/actions/valuedesclink.cpp
Log Message:
-----------
ValueDescLink: remove useless code: found_inverse is always false
Commit: c0409aad967caacc1e115d47f391aecee88eed72
https://github.com/synfig/synfig/commit/c0409aad967caacc1e115d47f391aecee88eed72
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2021-07-05 (Mon, 05 Jul 2021)
Changed paths:
M synfig-studio/src/synfigapp/actions/valuedesclink.cpp
Log Message:
-----------
ValueDescLink: reduce variable scope and use for-ranged loop
Commit: 9acfd9c0e1b42b5bdf6a31747930d2be855224ee
https://github.com/synfig/synfig/commit/9acfd9c0e1b42b5bdf6a31747930d2be855224ee
Author: ice0 <konop...@gmail.com>
Date: 2021-07-05 (Mon, 05 Jul 2021)
Changed paths:
M synfig-studio/src/synfigapp/actions/valuedesclink.cpp
M synfig-studio/src/synfigapp/actions/valuedesclink.h
M synfig-studio/src/synfigapp/value_desc.h
Log Message:
-----------
Merge PR #2206: Clean synfigapp::ValueDesc a bit
Clean synfigapp::ValueDesc a bit
Compare: https://github.com/synfig/synfig/compare/2c2062c5d115...9acfd9c0e1b4
_______________________________________________
Synfig-devl mailing list
Synfig-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/synfig-devl
