Branch: refs/heads/master
Home: https://github.com/synfig/synfig
Commit: dba2df7212b52d1033932ccd19b03e527bee1ead
https://github.com/synfig/synfig/commit/dba2df7212b52d1033932ccd19b03e527bee1ead
Author: Rodolfo Ribeiro Gomes <[email protected]>
Date: 2023-08-26 (Sat, 26 Aug 2023)
Changed paths:
M synfig-studio/src/gui/statemanager.cpp
M synfig-studio/src/gui/statemanager.h
Log Message:
-----------
refactor: avoid double call of change_state_()
Gtk 3 docs indirectly say that Gtk::RadioAction::signal_activate() is
called twice when an radio action is activated: one for current active
and another to the previous active action.
(see Gtk::RadioAction::signal_changed() description)
Besides Gtk::RadioAction::signal_activate() does not provide a good way
to check whether the called action is currently active or not.
Conclusion is Dock_Toolbox::change_state_() is called twice every time
user switches the current tool.
My solution: I switched to Gtk::RadioAction::signal_changed() that
provides proper info and allows us to call Dock_Toolbox only once.
Commit: 94a308fdff2cf5ff5f224438eeed9145e4252991
https://github.com/synfig/synfig/commit/94a308fdff2cf5ff5f224438eeed9145e4252991
Author: Rodolfo Ribeiro Gomes <[email protected]>
Date: 2023-08-26 (Sat, 26 Aug 2023)
Changed paths:
M synfig-studio/src/gui/docks/dock_toolbox.cpp
Log Message:
-----------
fix: Dock_Toolbox does not update selected tool when switching open docs
Reproduction steps:
1. Open Synfig Studio
2. Change to Circle Tool
3. Check if Circle Tool is active by moving mouse over Canvas View
(no need to create anything, just check the cursor icon)
4. Open new document
5. Circle Tool is marked as active, but it is not: check cursor icon
6. Change to Transform Tool
7. Switch to previous document tab
8. Transform Tool is marked as active, but it is not: check cursor icon
Commit: c6755c56ee0adffc4afeeb1c5c512e83582f1d02
https://github.com/synfig/synfig/commit/c6755c56ee0adffc4afeeb1c5c512e83582f1d02
Author: Rodolfo Ribeiro Gomes <[email protected]>
Date: 2023-08-26 (Sat, 26 Aug 2023)
Changed paths:
M synfig-studio/src/gui/docks/dock_toolbox.cpp
M synfig-studio/src/gui/docks/dock_toolbox.h
Log Message:
-----------
refactor: remove the now unneeded 'mutex' variable in Dock_Toolbox
Commit: 09e01f07ec4b02fefd4ec2428cbec39ae263fda2
https://github.com/synfig/synfig/commit/09e01f07ec4b02fefd4ec2428cbec39ae263fda2
Author: ice0 <[email protected]>
Date: 2023-08-27 (Sun, 27 Aug 2023)
Changed paths:
M synfig-studio/src/gui/docks/dock_toolbox.cpp
M synfig-studio/src/gui/docks/dock_toolbox.h
M synfig-studio/src/gui/statemanager.cpp
M synfig-studio/src/gui/statemanager.h
Log Message:
-----------
fix: toolbox isn't updated when switching document tabs (#3170)
Compare: https://github.com/synfig/synfig/compare/567c7964576c...09e01f07ec4b
_______________________________________________
Synfig-devl mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/synfig-devl
