Hello,
Coverity found some new small issues between releases 185-188. See attached
patches.
Regards
Lukas
>From b258ab8b5fec97e924ba5d3784be9b72d7966118 Mon Sep 17 00:00:00 2001
From: Lukas Nykryn <lnyk...@redhat.com>
Date: Mon, 20 Aug 2012 14:33:21 +0200
Subject: [PATCH 1/4] load-fragment: initialize bool invert before use
---
src/core/load-fragment.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/core/load-fragment.c b/src/core/load-fragment.c
index 1068130..47a7f4f 100644
--- a/src/core/load-fragment.c
+++ b/src/core/load-fragment.c
@@ -2028,7 +2028,7 @@ int config_parse_syscall_filter(
ExecContext *c = data;
Unit *u = userdata;
- bool invert;
+ bool invert = false;
char *w;
size_t l;
char *state;
--
1.7.6.5
>From 72b050672944143d846bc2059e2dec5ea7ad04fb Mon Sep 17 00:00:00 2001
From: Lukas Nykryn <lnyk...@redhat.com>
Date: Mon, 20 Aug 2012 14:39:08 +0200
Subject: [PATCH 2/4] login: check return of parse_pid and parse_uid
---
src/login/logind-inhibit.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/login/logind-inhibit.c b/src/login/logind-inhibit.c
index 96b7c6c..1803f8a 100644
--- a/src/login/logind-inhibit.c
+++ b/src/login/logind-inhibit.c
@@ -220,10 +220,16 @@ int inhibitor_load(Inhibitor *i) {
i->mode = mm;
if (uid)
- parse_uid(uid, &i->uid);
+ r = parse_uid(uid, &i->uid);
+
+ if (r < 0)
+ goto finish;
if (pid)
- parse_pid(pid, &i->pid);
+ r = parse_pid(pid, &i->pid);
+
+ if (r < 0)
+ goto finish;
if (who) {
cc = cunescape(who);
--
1.7.6.5
>From 36642c2aef0c441da508c1bb7ff68d69441f023f Mon Sep 17 00:00:00 2001
From: Lukas Nykryn <lnyk...@redhat.com>
Date: Mon, 20 Aug 2012 14:52:07 +0200
Subject: [PATCH 3/4] core: free word later in parse_proc_cmdline
---
src/core/main.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/core/main.c b/src/core/main.c
index cdd77c1..16e8b35 100644
--- a/src/core/main.c
+++ b/src/core/main.c
@@ -727,12 +727,13 @@ static int parse_proc_cmdline(void) {
}
r = parse_proc_cmdline_word(word);
- free(word);
-
if (r < 0) {
log_error("Failed on cmdline argument %s: %s", word, strerror(-r));
+ free(word);
goto finish;
}
+
+ free(word);
}
r = 0;
--
1.7.6.5
>From e455c40879578901943ce16f000b671449a9fc5a Mon Sep 17 00:00:00 2001
From: Lukas Nykryn <lnyk...@redhat.com>
Date: Mon, 20 Aug 2012 15:15:40 +0200
Subject: [PATCH 4/4] readahead-analyze: don't call fclose on null
---
src/readahead/readahead-analyze.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/readahead/readahead-analyze.c b/src/readahead/readahead-analyze.c
index 11b2b2d..9a929c0 100644
--- a/src/readahead/readahead-analyze.c
+++ b/src/readahead/readahead-analyze.c
@@ -144,6 +144,7 @@ int main_analyze(const char *pack_path) {
return EXIT_SUCCESS;
fail:
- fclose(pack);
+ if(pack)
+ fclose(pack);
return EXIT_FAILURE;
}
--
1.7.6.5
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
