Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> writes: > I have now pushed a change that adds UNIT= or USER_UNIT= to most > syntax error messages. This patch mostly follows Oleksii's approach, > but extends it to all syntax parsing functions. >
For the last time I tried to use next approach: I added reporting callback to all parser functions. That was enough, because *userdata contains all nessesary information about call (because it's used by caller to store parsed data to). That makes further extentions less expensive.. > The 'issues' patch can now easily go on top, by hooking into > log_syntax_internal. What is supposed way to hook with log_syntax_internal? Address unit data by name? conf-parser called not only for parsing unit files, but configuration files of services too.. Probably I'll replace *unit with *reporter and move log_struct calling to the callback owner instead. _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
