On Tue, 25.03.14 01:17, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote:
> > On Mon, Mar 24, 2014 at 07:43:00PM +0100, Lennart Poettering wrote: > > On Mon, 24.03.14 17:48, Lennart Poettering (lenn...@poettering.net) wrote: > > To me it really appears as if "_netdev" is the right thing to use here, > > and we really should advertise its use for cases like this, and close > > the bug as WONTFIX or NOTABUG... > > > > I mean, the fact that we imply _netdev behaviour with nfs, and so on is > > mostly to be compatibile with old fstabs. But given that glusterfs is > > already documented explicitly to require _netdev, like for example here: > > > > http://gluster.org/community/documentation/index.php/Gluster_3.1:_Automatically_Mounting_Volumes > > > > And given that we really shouldn't attempt to add every possible network > > fs in the world to our list I think we shouldn't add this at all here. > OTOH, requiring _netdev seems rather user-unfriendly. I think the failure mode > is rather unpleasant: everything seems to work, but at shutdown (sometimes) > the fs doesn't get unmounted. > > I wouldn't mind adding "all" network filesystems to the list: we > probably already have most of them, and it's not like new ones show up > every week. Actually removing the "fuse." prefix before the check also > seems trivial. > > I think the patch should be merged. Hmm, this would have one advantage, I mus agree: mounts we pick up from /proc/self/mountinfo (i.e. which weren't listed in /etc/fstab), currently cannot be ordered properly against remote-fs.target (thus creating problems at shutdown where we might shutdown network before those fs) I am still a bit concerned regarding adding any fs that might pop up though. But I then again, glusterfs is probably a relatively safe bet that it stays around... Hmm, I have now added glusterfs to the table (and also strips the fuse prefix). I hope this settles the issue. Lennart -- Lennart Poettering, Red Hat _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel