On Mon, Apr 7, 2014 at 12:28 PM, Susant Sahani <sus...@redhat.com> wrote: >> + r = manager_init_kmod_ctx(m); >> Maybe just do >> >> manager->kmod_ctx = kmod_ctx_new(NULL, NULL); >> if (!manager->kmod_ctx) { >> r = -ENOMEM; >> etc... >> } >> >> and drop the wrapping function (see above). > > Any specific reason to drop it and do directly ?
Either way is fine. I just suggested the wrapper is not really adding much once you drop the unref() from it. Cheers, Tom _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel