Hi, I'm sending this to have some updates on the policy!
I did notice some issues and others still *to confirm*, so first I'm writing some policy tests to make sure we don't break. I'll clean what I've and get get back to you. For the moment can you please confirm: 1) I assume the policy.c on the master branch is the correct one to work on? 2) So buses and custom endpoints can have their own policy db. >From reading the sources, I assume: * The two *share* the same internal format! * The two are unrelated, and the endpoint policy takes precedence over the bus policy when doing the talk check! Thanks! On Sat, Jun 07, 2014 at 05:26:55PM +0100, Djalal Harouni wrote: > Signed-off-by: Djalal Harouni <tix...@opendz.org> > --- > policy.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/policy.c b/policy.c > index 5a9770d..6f2bb1f 100644 > --- a/policy.c > +++ b/policy.c > @@ -10,11 +10,8 @@ > * your option) any later version. > */ > > -#include <linux/device.h> > #include <linux/fs.h> > -#include <linux/idr.h> > #include <linux/init.h> > -#include <linux/module.h> > #include <linux/mutex.h> > #include <linux/sched.h> > #include <linux/sizes.h> > @@ -129,7 +126,7 @@ exit_free: > } > > /** > - * kdbus_policy_free - drop a policy database reference > + * kdbus_policy_db_free - drop a policy database reference > * @db: The policy database > */ > void kdbus_policy_db_free(struct kdbus_policy_db *db) > @@ -162,7 +159,7 @@ void kdbus_policy_db_free(struct kdbus_policy_db *db) > } > > /** > - * kdbus_policy_new() - create a new policy database > + * kdbus_policy_db_new() - create a new policy database > * @db: The location where to store the new database > * > * Return: 0 on success, negative errno on failure > @@ -294,7 +291,7 @@ kdbus_policy_cache_entry_new(struct kdbus_conn *conn_a, > } > > /** > - * kdbus_policy_check_send_access() - check if one connection is allowed > + * kdbus_policy_check_talk_access() - check if one connection is allowed > * to send a message to another connection > * @db: The policy database > * @conn_src: The source connection > -- > 1.9.0 > -- Djalal Harouni http://opendz.org _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel