On 2014-06-25 15:43, Thomas H.P. Andersen wrote:
On Thu, Jun 26, 2014 at 12:01 AM, Michael Biebl <mbi...@gmail.com> wrote:
2014-06-25 23:18 GMT+02:00 Adam Williamson <awill...@redhat.com>:
Hi, folks. I'm about 90% sure there's a fairly significant bug in the
systemd-sysv-generator that was introduced in 214. It's a bit
complicated, and the full details are at
https://bugs.freedesktop.org/show_bug.cgi?id=80537 . But the tl;dr
summary is this:

I have push a patch that I think should correct this.
260ad50f5b4a9795032e3119c64f838a2d03370d

The sysv parsing was moved to the generator in the following two
commits. If the fix does not work then it should be possible to just
revert those instead.
817e224bbce3ed157817961ef19c80a250845a05
95ed3294c632f5606327149f10cef1eb34422862

IIRC with the old sysv support that simply translated to

After=network.target. No Wants or Requires dependencies.

This was changed before I wrote the generator.
http://cgit.freedesktop.org/systemd/systemd/commit/src/core/service.c?id=0404c609f399b2092a3de52eef9d75b0dc12e94c&context=48

Sorry about all this.

No problem at all. The fix looks good to me - I thought it would be something along those lines. I tested it and it does the intended thing for all the cases I found that were bad before. It should probably go to the 214-stable branch, if we didn't miss anything. Thanks a lot!
--
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Reply via email to