On Mon, Jun 30, 2014 at 5:09 PM, Greg KH <gre...@linuxfoundation.org> wrote:
> > +/* make sure the hostname is not "localhost" */
> > +static bool is_localhost(const char *hostname) {
> > + char *hostend;
> > +
> > + assert(hostname);
>
> You only call this in one place, with an array on the stack, so it can
> never be NULL. So why check this at all?
>
> Other than that minor nit, this looks good, thanks for adding it.
>
I was thinking that this function might be called in the future in other
places as well so
it doesn't hurt to check. But I can nuke the assert.
-Eugene
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
