Lennart Poettering <lenn...@poettering.net> writes: > On Thu, 06.11.14 10:49, Jan Synacek (jsyna...@redhat.com) wrote: > >> I think that this patch might be a bit ineffective, as it calls >> unit_file_load() again just to get an InstallContext. I wasn't sure >> how to get Also= targets in any other way. >> >> If such change makes sense, this patch should probably be considered a >> preview rather than something to be committed right away. > > Hmm, wouldn't it be nicer to introduce a new UnitFileState enum value > for this? > > Maybe UNIT_FILE_ALSO or so? > > I am not sure I like the idea of implicitly following the Also= setting here, > due > to the awkwarndess if multiple units are listed and how to map exotic > states of that other unit back to ours... > > Would that make sense? > > Lennart
Yes, that makes sense. What should a string representation of UNIT_FILE_ALSO be? I don't think that reporting 'also' would feel right. Also, is there a better way to find out if unit has any Also= targets than how I did it? Cheers, -- Jan Synacek Software Engineer, Red Hat
signature.asc
Description: PGP signature
_______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
