On Mon, 09.03.15 19:11, Lennart Poettering (lenn...@poettering.net) wrote: > - plymouth_feedback_handler() is really broken. Is it supposed to read > from a SOCK_STREAM socket? If so, are all messages exactly 6 bytes > long? If not: the parser will be completely confused by multiple > incoming messages which are coalesced... Also, previously it would > read uninitialized data, if the bytes we read are shorter than > 6... I "fixed" that now with a safety check, so that we don't > process uninitialized data anymore, but this really needs to be fixed > properly.
And in a similar way client_progress_handler() is hosed too. Even worse: if a client sends messages byte-wise (which is absolutely OK on SOCK_STREAM) it will be kicked off the connection. This needs to be fixed. Lennart -- Lennart Poettering, Red Hat _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
