On Tue, 10.03.15 08:21, Martin Pitt (martin.p...@ubuntu.com) wrote: > > Please, be more careful with complex code like this, this needs more > > rounds of review before something like this can be merged... > > Okay. It went through 4 rounds of review on the ML and several folks > commented, there were no more outstanding/unaddressed review comments, > and it seemed to me that we had consensus on IRC to land this now. > Procedurally, what should I/we do next time before landing such large > patches? Wait for an explicit ack on the ML from you?
Well, if it's complex code like this, get Zbigniew or Kay or Tom or so to say it's OK... I mean, I actually *do* appreciate that you don't ask for every patch to be reviewed on the ML, to keep the traffic minimal. In this case I would simply have preferred more rounds than usual, since it's not trivial... > Thanks and sorry for the hassle, NP, Lennart -- Lennart Poettering, Red Hat _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
