Thanks for the follow-up, Jack! On Tue, May 11, 2010 at 5:17 PM, Jack Lloyd <ll...@randombit.net> wrote: > > Having some unit tests would help make sure SFTP doesn't rot in the > future, which is certainly highly desirable, but full test coverage is > not necessary (as far as my awarding the bounty is concererned, > anyway; Zooko may have different ideas on this).
David-Sarah have been writing a lot of tests! I believe their patch will meet our standards for tests. It appears that David-Sarah has written unit tests for more or less all of the behavior that they are adding or fixing. One detail that will probably *not* be thoroughly tested in v1.7 is an "end-to-end" or "known-answer" test which would catch, for example, bugs or incompatibilities in the pycrypto module: http://allmydata.org/trac/tahoe-lafs/ticket/953#comment:12 Bugs in the pycrypto module are not that rare, so it would be good to get end-to-end tests, but I don't consider that a blocker for v1.7. Regards, Zooko _______________________________________________ tahoe-dev mailing list tahoe-dev@allmydata.org http://allmydata.org/cgi-bin/mailman/listinfo/tahoe-dev