On Tuesday 23 July 2019 12:16 PM, Anand B Pillai wrote: > > Hi all, > > I have an open "PR" - for review purposes and early feedback only > - against my own master branch > of the foolscap fork from the py3kport branch. > > https://github.com/anvetsu/foolscap/pull/1
Okay, so this code is not yet ready to be raised as a PR against the original repos master because it passes just one test (test_banana.py). I fixed some basic issues which was causing the Travis job to not run but all tests except test_banana.py will *fail* on Python2 (and Python3). So there is no point in raising a PR against the original repo at the moment. The "PR" which I have raised against my own fork's master is so that - any one interested could take a look at the changes and comment. And if you are interested, you can checkout my repo and run the test_banana.py test (only) on Python2 and Python3 and verify (or otherwise) that it passes for you. Once I make all tests pass - against Python2 and Python3 - I will be in a position to raise a PR against the original repo. It will be a big PR at that stage. Another option if of course - if we get commit rights to Warner's repo, I can raise frequent PRs against an "integration" branch - as discussed in call - as soon as test (or multiple tests) are passing - with the understanding that CI checks may still fail. We keep incrementally merging against this branch till all tests pass(along with CI checks) and we finally merge the "integration" branch to foolscap master. Hope this is clear. Let me know if there are any questions. Thanks. > I'd like someone to review the changes. Kindly email me your github id > so I can add you > to the project - and as a reviewer. > > There are many changed files though you can ignore almost all of them > as they are changes made by the 2to3 tool > and focus on the files listed in the PR comment. > > Expectations: > > 1. Checkout the branch and try the "test_banana.py" test on Python3 > (Mine is 3.6.7, so try anything same and upwards) > and Python2 (2.7.15) > 2. Review the core files mentioned in the port and give feedback of any. > > I will close this "PR" after I get any feedback. > > Thanks. > > -- > Kind Regards, > > --Anand > > ----------------------------------- > Founder & Director, > > Anvetsu Technologies Pvt Ltd (OPC), > > https://www.anvetsu.com > https://www.anvetsu.training > ----------------------------------- -- Kind Regards, --Anand ----------------------------------- Founder & Director, Anvetsu Technologies Pvt Ltd (OPC), https://www.anvetsu.com https://www.anvetsu.training -----------------------------------
_______________________________________________ tahoe-dev mailing list [email protected] https://tahoe-lafs.org/cgi-bin/mailman/listinfo/tahoe-dev
