Alan wrote (24 Nov 2013 12:51:10 GMT) : > # IPs > - log_string = re.sub(r'\<([\d]{1,3}\.){3}[\d]{1,3}\>', > + log_string = re.sub(r'([\d]{1,3}\.){3}[\d]{1,3}', > r'[IP REMOVED]', > log_string) > # MAC addresses > - log_string = re.sub(r'\<([0-9a-fA-F]{2}:){5,}[0-9a-fA-F]{2}\>', > + log_string = re.sub(r'([0-9a-fA-F]{2}:){5,}[0-9a-fA-F]{2}',
I find it slightly disturbing to see regexp changes without any single example (be it in the commit message, some design doc, or executable specification^W^Wtest suite) of what strings are newly supposed to match or to not match anymore thanks to the change. Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc _______________________________________________ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev