sajolida:
> BitingBird:
>> BitingBird:
>>> Hi!
>>>
>>> Here is a small patch to add SanDisk Extreme to known issues (and change
>>> a bit the sentence underneath, because this SanDisk doesn't have the
>>> windows logo but still doesn't work.
>>>
>>> Cheers !
>>>
>>>  BitingBird
>>
>> Actually, I also added the Sony SD Card - so please apply this patch
>> instead, it has the commits for both unsupported devices.
> 
> I'm fine with your change to the SanDisk section as frontdesk also
> reported something similar lately.
> 
> Regarding the Sony SD card, I would like to be a bit more careful before
> adding it. Where did you get that information from? What was happening?

I added the ones listed in https://labs.riseup.net/code/issues/6397

> Could you ask this person to run the following command:
> 
> sudo find /sys/devices -path "*sd*/removable" -print -exec cat '{}' \;
> 
> This returns the status of the removable flag on the device.

I'll edit the ticket to ask goupille to do that (they's the one who
reported it, I guess it was a whisperback report).

> Also note that your patch is much longer than what it needs because you
> rewrapped many lines that were not changed otherwise. This makes it much
> harder to review and will break `git blame` for no reason on many lines.
> Please try to reduce it to the minimum.
> 
> I know that I'm sometimes a bit maniac with rewrapping myself, but I'm
> on rehab :)
> 
I'll try not to do that in the future, but I'd really prefer not to redo
the patch for this.

Cheers!

 BitingBird
_______________________________________________
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.

Reply via email to