Author: hlship
Date: Wed Nov 9 08:08:17 2005
New Revision: 332074
URL: http://svn.apache.org/viewcvs?rev=332074&view=rev
Log:
TAPESTRY-742: LinkSubmit renders overly verbose JavaScript
Modified:
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/Form.js
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/LinkSubmit.script
jakarta/tapestry/trunk/status.xml
Modified:
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/Form.js
URL:
http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/Form.js?rev=332074&r1=332073&r2=332074&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/Form.js
(original)
+++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/Form.js
Wed Nov 9 08:08:17 2005
@@ -110,6 +110,15 @@
event.invalid_field(field, message);
}
+// Used by LinkSubmit components to force the form to submit
+
+Tapestry.submit_form = function(form_id, field_name)
+{
+ var form = this.find(form_id);
+
+ form.events.submit(field_name);
+}
+
// FormSubmitEvent
//
// Event object that identifies the form that was submitted,
Modified:
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/LinkSubmit.script
URL:
http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/LinkSubmit.script?rev=332074&r1=332073&r2=332074&view=diff
==============================================================================
---
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/LinkSubmit.script
(original)
+++
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/LinkSubmit.script
Wed Nov 9 08:08:17 2005
@@ -23,22 +23,8 @@
<input-symbol key="name" class="java.lang.String" required="yes"/>
<input-symbol key="form" class="org.apache.tapestry.IForm" required="yes"/>
-<let key="functionName" unique="yes">
- onclick_${hiddenId}
-</let>
-
<let key="href">
- javascript:${functionName}();
+ javascript:Tapestry.submit_form('${form.name}', '${name}');
</let>
-
-<body>
-function ${functionName}()
-{
- var form = Tapestry.find('${form.name}');
-
- form.events.submit('${name}');
-}
-
-</body>
</script>
Modified: jakarta/tapestry/trunk/status.xml
URL:
http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/status.xml?rev=332074&r1=332073&r2=332074&view=diff
==============================================================================
--- jakarta/tapestry/trunk/status.xml (original)
+++ jakarta/tapestry/trunk/status.xml Wed Nov 9 08:08:17 2005
@@ -54,6 +54,7 @@
<action type="update" dev="HLS">Switch to HiveMind 1.1 (final)</action>
<action type="fix" dev="HLS" fixes-bug="TAPESTRT-678">LinkSubmit does
not work correctly when the browser's back button is used and the form
resubmitted normally</action>
<action type="add" dev="HLS" fixes-bug="TAPESTRY-731">Extend
RequestDisplay component (used on the Exception page) to also report the
internal status of key Tapestry services</action>
+ <action type="fix" dev="HLS" fixes-bug="TAPESTRY-742">LinkSubmit renders
overly verbose JavaScript</action>
</release>
<release version="4.0-beta-12" date="Oct 30 2005">
<action type="fix" dev="HLS" fixes-bug="TAPESTRY-718">Asset injection
makes assets appear as null inside finishLoad()</action>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
