[ 
http://issues.apache.org/jira/browse/TAPESTRY-819?page=comments#action_12361345 
] 

Howard M. Lewis Ship commented on TAPESTRY-819:
-----------------------------------------------

The test case is not valid.  Tapestry components that need to render an id must
a) pass their id through IRequestCycle.getUniqueId() to handle cases where the 
same component renders multiple times
b) Use TapestryUtils.convertTapestryIdToNMToken()

You are working from the incorrect assumption that Tapestry component ids must 
be valid (X)HTML element ids. This has never been the case in the past.  
Because Tapestry components may render multiple times, it is not even 
desirable. Your specific approach .. replacing dollar signs with slashes, will 
cause many other problems w.r.t. friendly URLs (the final slash in the path 
info must be the dividing point between the page name and the component id 
path).

The example i was looking for would be a component, such as (say) Submit, that 
renders an id attribute that is not unique and a NMTOKEN (the XML type that 
governs the format of the id attribute). It is unfortunate, or unavoidable, 
that you can create code and components that generate invalid (X)HTML, but that 
was never the point of the framework (to prevent that possibility).

> $ signs in generated element names / ids are illegal in XHTML - in slashed 
> component names
> ------------------------------------------------------------------------------------------
>
>          Key: TAPESTRY-819
>          URL: http://issues.apache.org/jira/browse/TAPESTRY-819
>      Project: Tapestry
>         Type: Bug
>     Versions: 4.0
>     Reporter: Leonardo Quijano Vincenzi
>     Assignee: Howard M. Lewis Ship
>      Fix For: 4.0

>
> $ signs in generated element names / ids are illegal in XHTML.  The 
> auto-generation algorithm would need to change.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to