Bugs item #603362, was opened at 2002-09-02 03:25
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=104754&aid=603362&group_id=4754

Category: Tapestry
Group: bug
Status: Open
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Howard Lewis Ship (hship)
Summary: Inconsistency in Tapestry_1_3.dtd

Initial Comment:
There appears to be a bug in the Tapestry_1_3.dtd on 
line 250 for setting bean properties:

<!ELEMENT expression-value EMPTY>
<!ATTLIST property-value
   expression CDATA #REQUIRED
>

should be:

<!ELEMENT expression-value EMPTY>
<!ATTLIST expression-value
   expression CDATA #REQUIRED
>

----------------------------------------------------------------------

>Comment By: Howard Lewis Ship (hship)
Date: 2002-09-02 09:13

Message:
Logged In: YES 
user_id=26816

Hopefully, this won't screw poor Geoff, desperately trying to 
keep up with these changes to put them into Spindle.

----------------------------------------------------------------------

Comment By: Howard Lewis Ship (hship)
Date: 2002-09-02 09:12

Message:
Logged In: YES 
user_id=26816

Now that I've had to do something I didn't want (change the 
DTD in beta), I realized that with OGNL I can do a lot better.

Example:

<bean ...>
  <set-property name="foo" expression="..."/>
  <set-string-proprerty name="bar" key="...."/>
</bean>

Since OGNL already has better constants (equivalent of 
static-value) and field lookup (equivalent of field-value), those 
elements aren't useful, and we end up with something much 
simpler.

For example, from the Workbench Fields page, we go from:

  <bean name="intValidator" 
class="net.sf.tapestry.valid.NumberValidator">
        <set-property name="required">
                <field-value field-
name="Boolean.TRUE"/>
        </set-property>
        <set-property name="minimum">
                <field-value field-
name="tutorial.workbench.fields.Fields.INT_MIN"/>
        </set-property>
        <set-property name="maximum">
                <field-value field-
name="tutorial.workbench.fields.Fields.INT_MAX"/>
        </set-property>
  </bean>

  <bean name="intValidator" lifecycle="render" 
class="net.sf.tapestry.valid.NumberValidator">
        <set-property name="required" expression="true"/>
        <set-property name="minimum" 
expression="@tutorial.workbench.fields.Fields@INT_MIN"/>
        <set-property name="maximum" 
expression="@tutorial.workbench.fields.Fields@INT_MAX"/>
  </bean>

Which is much more readable (to me anyway!).

----------------------------------------------------------------------

Comment By: Malcolm Edgar (malcolm_edgar)
Date: 2002-09-02 03:27

Message:
Logged In: YES 
user_id=592290

This was submitted by malcolm_edgar. I forgot to login with 
initial submission

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=104754&aid=603362&group_id=4754


-------------------------------------------------------
This sf.net email is sponsored by: OSDN - Tired of that same old
cell phone?  Get a new here for FREE!
https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390
_______________________________________________
Tapestry-developer mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/tapestry-developer

Reply via email to