Hi Viktor,
> i think it would improve the usability of the paging behaviour, if the
> all the arrows were displayed if there's more than one page - regardless
> of which page you're on. that is, the back arrows should be displayed
> even if you're on the first page (as disabled links of course)... this
> way the page list would not jump around...
Good point. Consider it done.
> btw, i had no trouble using the Table component, good job :) there are a
> few minor things to improve, but it's nice in general.
Thank you :)
> i think a useful addition would be something like a generic BlockColumn
> helper class (similar to the ones declared in the workbench example), eg:
A very good suggestion, I would definitely consider it. You are right that it might be quite useful.
> the only thing that this is missing is setting the current row on the
> component.. i don't know if it would be possible to make currentRow an
> outgoing binding on the Table component, but i think it would be
> useful... it doesnt really make sense to call a setter for every column
> in a row, instead of 1 per row.
The TableRows component has a 'value' binding that does exactly that. I did not think it would be a good idea to expose this from Table, but I might reconsider as a result. Will think about it.
Thanks,
-mb
P.S. Thanks for the copy :)
[EMAIL PROTECTED] wrote:
hi,
i think it would improve the usability of the paging behaviour, if the
all the arrows were displayed if there's more than one page - regardless
of which page you're on. that is, the back arrows should be displayed
even if you're on the first page (as disabled links of course)... this
way the page list would not jump around...
btw, i had no trouble using the Table component, good job :) there are a
few minor things to improve, but it's nice in general.
i think a useful addition would be something like a generic BlockColumn
helper class (similar to the ones declared in the workbench example), eg:
public class BlockColumn extends SimpleTableColumn {
private final ComponentAddress componentAddress;
private final String blockName;
public BlockColumn(ComponentAddress componentAddress, String title, String blockName) {
super(title, true);
this.blockName = blockName;
this.componentAddress = componentAddress;
}
public IRender getValueRenderer(IRequestCycle cycle, ITableModelSource source, Object row) {
IComponent comp = componentAddress.findComponent(cycle);
// !!! the examples set the current row on the component here, so that the blocks can easily access it
Block block = (Block) comp.getComponent(this.blockName);
return new BlockRenderer(block);
}
}
the only thing that this is missing is setting the current row on the
component.. i don't know if it would be possible to make currentRow an
outgoing binding on the Table component, but i think it would be
useful... it doesnt really make sense to call a setter for every column
in a row, instead of 1 per row.
best regards,
viktor
--
[EMAIL PROTECTED]
--
http://fastmail.fm - Sent 0.000002 seconds ago
-------------------------------------------------------
This SF.net email is sponsored by: ApacheCon, November 18-21 in
Las Vegas (supported by COMDEX), the only Apache event to be
fully supported by the ASF. http://www.apachecon.com
_______________________________________________
Tapestry-developer mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/tapestry-developer
Do you Yahoo!?
HotJobs - Search new jobs daily now
