Bugs item #673665, was opened at 2003-01-23 17:05
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=104754&aid=673665&group_id=4754
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Eric Everman (eeverman)
Assigned to: Nobody/Anonymous (nobody)
Summary: isRewinding incorrect in pageEndRender Event
Initial Comment:
During a rewind, cycle.isRewinding returns true until
just *before* the pageEndRender event is fired. This
seems incorrect, since the page may need to initialize
or cleanup in the render events and pageEndRender will
*always* return isRewinding as false.
>From RequestCycle.rewindForm(IForm, targetActionId), I
would suggest changing the finally clause from:
finally {
_rewinding = false;
_actionId = 0;
_targetActionId = 0;
_targetComponent = null;
page.endPageRender();
}
to:
finally {
_actionId = 0;
_targetActionId = 0;
_targetComponent = null;
page.endPageRender();
_rewinding = false;
}
Eric Everman
----------------------------------------------------------------------
>Comment By: Eric Everman (eeverman)
Date: 2003-01-23 17:19
Message:
Logged In: YES
user_id=219939
Just noticed that the monitor will also show the incorrect
rewind state. The _monitor reference should be moved into
the finally clause like this:
/////////////////////////
finally
{
_actionId = 0;
_targetActionId = 0;
_targetComponent = null;
page.endPageRender();
_monitor.pageRewindEnd(pageName);
_rewinding = false;
}
//_monitor.pageRewindEnd(pageName); //removed
/////////////////////////////
A similar change needs to be made to the finally clause of
rewindPage:
////////////////////////////
finally
{
_actionId = 0;
_targetActionId = 0;
_targetComponent = null;
_monitor.pageRewindEnd(pageName);
_rewinding = false;
}
//_monitor.pageRewindEnd(pageName); //removed
/////////////////////////
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=104754&aid=673665&group_id=4754
-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com
_______________________________________________
Tapestry-developer mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/tapestry-developer
