Bugs item #679655, was opened at 2003-02-03 18:12
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=104754&aid=679655&group_id=4754

Category: Tapestry
Group: bug
Status: Open
Resolution: None
Priority: 5
Submitted By: Peter Levart (plevart)
Assigned to: Howard Lewis Ship (hship)
Summary: Upload component very slow on file uploads

Initial Comment:
This is for Tapestry 2.3-rc1 
 
When uploading files using Upload component I get roughly 
324 kByte/s transfer rate on a 2.4GHz Pentium 4 Linux server 
(uploading via localhost - browser on the same machine). 
 
With two simple modifications to two classes I can get 35x 
improvement (11.5 MByte/s) on the same machine. 
 
Attatched are the diffs to: 
 
net.sf.tapestry.multipart.LineInput  and 
net.sf.tapestry.multipart.UploadOutputStream 
 
The private DefaultMultipartDecoder.readIntoStream() method 
would also need some trimming and this could speed up things 
for another magnitude. But for 2.3 release at least theese two 
changes could go in. 
 
Peter 
 

----------------------------------------------------------------------

>Comment By: Peter Levart (plevart)
Date: 2003-02-08 20:26

Message:
Logged In: YES 
user_id=346981

I have now modified the DefaultMultipartDecoder.readIntoStream(...)  
method to be more efficient. I also had to modify the semantics of the  
LineInput.readLine() method to return null when the stream is already  
positioned at the EOF. I will produce the benchmarks on monday  
when I will measure them on the same machine. I belive uploading will  
be up to 50% faster then with original DefaultMultipartDecoder and  
buffered input/output streams, which means it will be 50x as fast as it  
is now in Tapestry-2.3-rc-1...  
  
Attatched are the 3 modified source files that superceede previous 2 
diffs: 
 
- DefaultMultipartDecoder.java 
- UploadOutputStream.java 
- LineInput.java 
 

----------------------------------------------------------------------

Comment By: Peter Levart (plevart)
Date: 2003-02-03 18:13

Message:
Logged In: YES 
user_id=346981

Forgot to check the upload checkbox. 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=104754&aid=679655&group_id=4754


-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com
_______________________________________________
Tapestry-developer mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/tapestry-developer

Reply via email to