Branch: refs/heads/net-split
Home: https://github.com/mailru/tarantool
Commit: 3f3232c4fb9ac63faf2bf39597771151945cde24
https://github.com/mailru/tarantool/commit/3f3232c4fb9ac63faf2bf39597771151945cde24
Author: Konstantin Osipov <[email protected]>
Date: 2012-09-19 (Wed, 19 Sep 2012)
Changed paths:
M include/fiber.h
M include/iproto.h
M include/net_io.h
M mod/box/txn.m
M src/admin.m
M src/admin.rl
M src/fiber.m
M src/iproto.m
M src/net_io.m
M src/replica.m
M src/say.m
M test/box/admin.result
Log Message:
-----------
net-split, code review (1, 2, 3)
Temporarily remove support of fiber peer and cookie.
The idea of the cookie is to preserve in the WAL
the originator of the request. This information is, however,
lost when saving a snapshot. To my knowledge there is no use
of this functionality, apart from pretty-printing
the WAL.
Peer is like cookie, but is textual and is used
for logging. However, now, as long as network errors
occur outside fiber context, most of the usefulness
is lost. The only remaining case is when someone is
trying to execute a write request on a read-only port.
The right solution is to pass these things
around explicitly.
And sock.m needs to be fixed to supply SocketError
with peer name, since this is where it's most useful.
Remove auxiliary methods conn_{start,stop}_{input,output}.
Remove the global connections tab.
For global audit, this needs to be done on the sock.m level,
and that's where we need to record the socket peer (for error
messages).
Remove show net statement, since it needs to be implemented
using an interator over sock.m subsystem, not by
passing a tbuf into a Connection call.
Remove Connection methods read, write, writev
Replace message send with direct invocation
of sock API.
Commit: a24c626329e4e150d3a74dd9dfbf35876befef09
https://github.com/mailru/tarantool/commit/a24c626329e4e150d3a74dd9dfbf35876befef09
Author: Konstantin Osipov <[email protected]>
Date: 2012-09-19 (Wed, 19 Sep 2012)
Changed paths:
M include/net_io.h
A include/sio.h
R include/sock.h
M src/CMakeLists.txt
M src/admin.m
M src/admin.rl
M src/iproto.m
M src/net_io.m
M src/replication.m
A src/sio.m
R src/sock.m
Log Message:
-----------
Rename sock.[h,m] to sio.[h,m].
Commit: 27445ea5b7eba7b607a2d1c857280f9f4035b589
https://github.com/mailru/tarantool/commit/27445ea5b7eba7b607a2d1c857280f9f4035b589
Author: Konstantin Osipov <[email protected]>
Date: 2012-09-28 (Fri, 28 Sep 2012)
Changed paths:
M cfg/core_cfg.cfg_tmpl
M include/exception.h
M include/net_io.h
M include/sio.h
M src/exception.m
M src/fiber.m
M src/iproto.m
M src/net_io.m
M src/replication.m
M src/say.m
M src/sio.m
M src/tarantool.m
Log Message:
-----------
net-split, code review (3): make sio API a simpe wrapper around POSIX
Make sio.[h,m] API simply an exception-aware wrapper around
POSIX socket API. Don't provide any other "added value". A single
layer got to do just one thing, to have chances to be reusable. This
also makes code more compact.
Remove sio_setsockopt_nothrow, if we get an exception
of this kind, better to close connection than continue.
Compare: https://github.com/mailru/tarantool/compare/58d9c1500333...27445ea5b7eb
_______________________________________________
Mailing list: https://launchpad.net/~tarantool-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~tarantool-developers
More help : https://help.launchpad.net/ListHelp
