On Mon, 1 Dec 2008, Frank Niessink wrote: > 2008/12/1 Jerome Laheurte <[EMAIL PROTECTED]>: >> On Sun, 30 Nov 2008, Frank Niessink wrote: >> >>> Hi Jérôme, >>> >>> Saving may fail when TC cannot open a (mail) attachment. See attached >>> screenshot. I'm not sure what the best place is to catch the error, >>> but I do think TC should continue saving the file. Any suggestions? >> >> I'd say around the "data = attachment.data()" line in xml/writer.py. >> >> This won't be a issue any more since mail attachment data is now >> stored in the .tsk file. Less headache. > > So I can safely ignore any exceptions in that line? Or should the user > be notified?
I was wondering. I think we can just ignore it. If the file doesn't exist anymore, the user probably don't need it (say, the task has been completed and hidden), or he would have complained about not being able to open it. On second thoughts, the try/except should be one level above, around the call to attachmentNode(...), so that attachments with this problem are just removed. Cheers Jérôme
