[taskcoach-dev] Dirty question :-)

[Frank Niessink]

Hi,

I've activated pylint in Eclipse/PyDev and I'm going through the
hundreds of pyline errors and warnings. That's really useful. For
example, it complained about the use of category in taskfile.py,
TaskFile.onCategoryChanged:

    def onCategoryChanged(self, event):
        if self.__loading:
            return
        categories = [category for category in event.sources() if \
                      category in self.categories()]
        if categories:
            self.markDirty()
            for categorizable in category.categorizables():
                categorizable.markDirty()

What is the last loop supposed to do? Mark the categories dirty, or
mark all the categorizables belonging to the changed categories as
dirty? In either case, the loop as it is now is clearly wrong.

Thanks, Frank