David Binderman wrote on 2013-11-20:
> hello there,
>
> I recently ran the static analyser "cppcheck" over the source code of
> tboot-1.7.3
>
> It said
>
> [common/hash.c:137] -> [common/hash.c:137]: (style) Same expression on
> both sides of '||'.
>
> Source code is
>
> void copy_hash(tb_hash_t *dest_hash, const tb_hash_t *src_hash,
> uint8_t hash_alg)
> {
> if ( dest_hash == NULL || dest_hash == NULL ) {
> printk(TBOOT_WARN"hashes are NULL\n");
> return;
> }
>
> Suggest change the second mention of dest_hash to src_hashThanks a lot for reporting tboot issues here, I will fix it soon. Jimmy
smime.p7s
Description: S/MIME cryptographic signature
------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
_______________________________________________ tboot-devel mailing list tboot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tboot-devel
