Whether TPM 2.0 support 2 banks or 3 banks,but tboot code only supports two
algorithms at present,as follows:
u16 tboot_alg_list[] = {TB_HALG_SHA1, TB_HALG_SHA256};
After with my patch,tboot log out is as follows:
TBOOT: TPM: supported bank count = 3
TBOOT: TPM: bank alg = 00000004
TBOOT: TPM: bank alg = 0000000b
TBOOT: TPM: bank alg = 00000012
TBOOT: tboot: supported alg count = 2
TBOOT: tboot: hash alg = 00000004
TBOOT: tboot: hash alg = 0000000B
Without my patch,tboot log out is as follows:
TBOOT: TPM: supported bank count = 3
TBOOT: TPM: bank alg = 00000004
TBOOT: TPM: bank alg = 0000000b
TBOOT: TPM: bank alg = 00000012
TBOOT: TPM: supported alg count = 00000002
TBOOT: 00000004
TBOOT: 0000000B
Thanks,
Wangyi
From: Sun, Ning
Date: 2017-04-05 07:58
To: shiwan...@gohighsec.com; tboot-devel
Subject: RE: [tboot-devel] Fixed an expression and output format problem
Thanks for the patch.
AFAIK, there are some TPM 2.0 support 2 banks, some TPM 2.0 support 3 banks.
Do you mean tboot just print out 2 banks on a TPM 2.0 with 3 banks?
-ning
From: shiwan...@gohighsec.com [mailto:shiwan...@gohighsec.com]
Sent: Monday, April 03, 2017 5:36 AM
To: tboot-devel <tboot-devel@lists.sourceforge.net>
Subject: [tboot-devel] Fixed an expression and output format problem
Hi,
There is an expression and output format problem.
Firstly,number of algorithms should be %d instead of %08X,it will be more
readable.
Secondly,log expression is not accurate.Tpm2.0 supports three algorithms,as
follows:
TBOOT: TPM: supported bank count = 3
TBOOT: TPM: bank alg = 00000004
TBOOT: TPM: bank alg = 0000000b
TBOOT: TPM: bank alg = 00000012
But tboot code supports two algorithms at present. So "printk(TBOOT_INFO"TPM:
supported alg count = %08X\n", ti->alg_count);"
should be changed to "printk(TBOOT_INFO"tboot: supported alg count = %d\n",
ti->alg_count);".
Signed-off-by: Shi Wangyi<shiwan...@gohighsec.com>
diff -r 2ec88c2dd07b -r c79d9a0558c0 tboot/common/tpm_20.c
--- a/tboot/common/tpm_20.c Fri Feb 17 03:55:19 2017 -0800
+++ b/tboot/common/tpm_20.c Sun Apr 02 09:58:00 2017 -0400
@@ -2319,9 +2319,9 @@
ti->alg_count++;
}
}
- printk(TBOOT_INFO"TPM: supported alg count = %08X\n", ti->alg_count);
+ printk(TBOOT_INFO"tboot: supported alg count = %d\n", ti->alg_count);
for (unsigned int i=0; i<ti->alg_count; i++)
- printk(TBOOT_INFO"\t\t %08X\n", ti->algs[i]);
+ printk(TBOOT_INFO"tboot: hash alg = %08X\n", ti->algs[i]);
if (handle2048 != 0)
goto out;
Thanks,
Wangyi
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
tboot-devel mailing list
tboot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tboot-devel
