Hello Matthias,
We will review your patch in the future. However our team needs first to
implement
several urgent features for TBOOT MLE, before we take care of your
changeset.
Regards,
Michal Camacho Romero
On 1/23/2026 12:07 PM, Matthias Gerstner wrote:
Hello list,
although it seems there is no longer an active upstream for tboot, here
is a patch for a compiler error/warning in tboot which occurs with
gcc-16. Maybe at least other users of tboot can make use of it.
The diagnostic is as follows:
safeclib/strpbrk_s.c: In function ‘strpbrk_s’:
safeclib/strpbrk_s.c:95:13: error: variable ‘len’ set but not used
[-Werror=unused-but-set-variable=]
95 | rsize_t len;
| ^~~
cc1: all warnings being treated as errors
It seems that this function does not take the `slen` parameter into
account at all, thereby not providing the safety guarantees that the
function's signature suggests. My take on fixing the issue is found in
the attached patch. Hopefully this doesn't cause any regressions in
spots where this shortcoming has masked errors before.
Cheers
Matthias
_______________________________________________
tboot-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tboot-devel
_______________________________________________
tboot-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tboot-devel
