Andy Chittenden wrote:
Rather than using OS specific #defines, wouldn't it be better to use
HAVE_SYS_FILE_H and set that appropriately for MSDOS (and our embedded
OS)?
One problem with doing that is that pcap.h includes other header files,
so if it did that, either
1) HAVE_SYS_FILE_H would have to be set in a header file installed with
libpcap and included by "pcap.h"
or
2) "pcap.h" would have to be generated from "pcap.h.in" and the #ifdef
processing for values such as HAVE_SYS_FILE_H done in the process
because having the installed "pcap.h" test any #define not set by a
header file that's part of libpcap is likely to cause all sorts of
unpleasantness (see, for example, the long comment in
"wiretap/file_wrappers.c" in Ethereal, about zlib's zconf.h depending on
HAVE_UNISTD_H).
-
This is the tcpdump-workers list.
Visit https://lists.sandelman.ca/ to unsubscribe.
