On Sun, Sep 02, 2001 at 08:27:02PM -0400, Nickolai Zeldovich wrote:
> This patch adds zephyr packet decoding to tcpdump..
1) You should probably add a BSD-style copyright notice (I have the
impression that the OpenBSD folks, for example, prefer to have the
copyright/license issues clear on code in their tree).
2) You might want to call it "print-zephyr.c" rather than "print-z.c".
3) There are some compiler warnings:
./print-zephyr.c: In function `parse_field':
./print-zephyr.c:63: warning: unused variable `fieldlen'
./print-zephyr.c: In function `str_to_lower':
./print-zephyr.c:96: warning: implicit declaration of function `strncpy'
./print-zephyr.c: At top level:
./print-zephyr.c:110: warning: no previous prototype for `z_print'
./print-zephyr.c: In function `z_print':
./print-zephyr.c:131: warning: implicit declaration of function `strncmp'
./print-zephyr.c:134: warning: implicit declaration of function `strtol'
./print-zephyr.c:196: warning: `c' might be used uninitialized in this function
./print-zephyr.c:196: warning: `i' might be used uninitialized in this function
with the "developer" GCC options added by "configure" (do "make
distclean", create a file ".devel" in the top-level source directory,
and then do "configure"; the ".devel" file will cause the configure
script to add some additional GCC options).
-
This is the TCPDUMP workers list. It is archived at
http://www.tcpdump.org/lists/workers/index.html
To unsubscribe use mailto:[EMAIL PROTECTED]?body=unsubscribe
