On Tue, Oct 16, 2001 at 08:38:12PM -0400, Kaarthik Sivakumar wrote:
> The for loop should be
>
> for (i = 0; i < bgpo.bgpo_optlen; /* Nothing */ ) {
>
> since i is getting incremented within the for loop. This results in
> the i going one value too far into the options list and so memcpy of
> bgpopt results in incorrect value. A patch is attached that corrects
> it. I am not sure what the correct patch format is. I am sending a
> 'diff -ur'.
>
> The patch also contains the identification of the Capabilities
> optional parameter (parameter type 2) in 'char *bgpopt_type[]'.
Checked in by itojun.
> I had sent a patch earlier today to [EMAIL PROTECTED] on
> print-mpls.c but I am not sure if I should send it to tcpdump-workers
> also. Could someone let me know about that? Thanks.
It looks as if it's a bug fix, so I'm inclined to add it to 3.7; if
anybody wants to check it, it's patch 273. There's probably no need to
send it to tcpdump-workers, as it's available in the patch archives.
-
This is the TCPDUMP workers list. It is archived at
http://www.tcpdump.org/lists/workers/index.html
To unsubscribe use mailto:[EMAIL PROTECTED]?body=unsubscribe
