I've registered with Trac on the tcpreplay.synfin.net site, but I guess
you have to manually enable submission privileges for me to be able to
submit tickets.
I got the following warning during compilation of the libopts library:
In file included from ../../libopts/libopts.c:2:
../../libopts/compat/compat.h:245:1: warning: "strchr" redefined
In file included from /usr/include/string.h:417,
from /usr/include/memory.h:30,
from ../../libopts/compat/compat.h:127,
from ../../libopts/libopts.c:2:
/usr/include/bits/string2.h:396:1: warning: this is the location of the
previous definition
The problem here is that libopts is using #ifdef HAVE_STRCHR, but the
config.h file used (generated as part of the tcpreplay/configure run)
doesn't actually check for strchr (which is present on this system,
really most nowadays as it is ANSI C). Fixes would be to change the
sense of the libopts test or add a check for strchr() in the tcpreplay
configure.in:
--- configure.in~ 2006-09-01 14:18:03.000000000 -0400
+++ configure.in 2006-09-01 16:18:18.000000000 -0400
@@ -119,7 +119,7 @@
AC_FUNC_MEMCMP
AC_TYPE_SIGNAL
AC_FUNC_VPRINTF
-AC_CHECK_FUNCS([gettimeofday ctime memset regcomp strdup strerror
strtol strncpy strtoull poll ntohll mmap snprintf vsnprintf])
+AC_CHECK_FUNCS([gettimeofday ctime memset regcomp strchr strdup
strerror strtol strncpy strtoull poll ntohll mmap snprintf vsnprintf])
dnl Look for strlcpy since some BSD's have it
AC_CHECK_FUNCS([strlcpy],have_strlcpy=true,have_strlcpy=false)
I also received some additional warnings during compilation of libopts.c
(I realize this is not your code, but I'm not sure where else to report
it, as no e-mail address for Bruce Korb is present):
In file included from ../../libopts/libopts.c:21:
../../libopts/putshell.c: In function 'optionPutShell':
../../libopts/putshell.c:203: warning: format '%1$ld' expects type 'long
int', but argument 2 has type 'uintptr_t'
../../libopts/putshell.c:203: warning: format '%1$lX' expects type 'long
unsigned int', but argument 2 has type 'uintptr_t'
The problem here is that a pointer type is being used, even though it is
actually a straight integer. While this is innocuous on a 32-bit
machine, there is a more serious problem on a 64-bit architecture, where
long types are 64 bits, but ints (unsigned or signed) are only 32 bits.
The val variable needs to be declared the same as it is used in the
printf, or the printf will grab 32 additional garbage bits from the stack.
There are a few other warnings, but they don't seem to reflect real
issues, as far as I can tell:
In file included from ../../libopts/libopts.c:27:
../../libopts/text_mmap.c: In function 'text_mmap':
../../libopts/text_mmap.c:116: warning: suggest parentheses around
comparison in operand of &
In file included from ../../libopts/libopts.c:28:
../../libopts/tokenize.c: In function 'ao_string_tokenize':
../../libopts/tokenize.c:243: warning: dereferencing type-punned pointer
will break strict-aliasing rules
../../libopts/tokenize.c:254: warning: dereferencing type-punned pointer
will break strict-aliasing rules
@alex
--
mailto:[EMAIL PROTECTED]
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Tcpreplay-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tcpreplay-users
